Skip to content

test(spanner): update pytest and add pytest-asyncio to samples test requirements - #17732

Merged
sakthivelmanii merged 1 commit into
mainfrom
fix-spanner-samples-pytest-asyncio-v2
Jul 16, 2026
Merged

test(spanner): update pytest and add pytest-asyncio to samples test requirements#17732
sakthivelmanii merged 1 commit into
mainfrom
fix-spanner-samples-pytest-asyncio-v2

Conversation

@sakthivelmanii

Copy link
Copy Markdown
Contributor

Updated pytest to <9 and >=8.2 and added pytest-asyncio to resolve dependency conflicts and support asynchronous test execution in samples.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@sakthivelmanii
sakthivelmanii requested a review from a team as a code owner July 16, 2026 09:08

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the pytest-asyncio dependency version in requirements-test.txt to 1.4.0. However, this version does not exist for pytest-asyncio, which will cause installation and dependency resolution to fail. It is recommended to use a valid version such as 0.25.1.

Comment thread packages/google-cloud-spanner/samples/samples/requirements-test.txt
…equirements

Updated pytest to <9 and >=8.2 and added pytest-asyncio to resolve dependency conflicts and support asynchronous test execution in samples.
@sakthivelmanii
sakthivelmanii force-pushed the fix-spanner-samples-pytest-asyncio-v2 branch from b52caaa to 3875731 Compare July 16, 2026 09:09
@sakthivelmanii
sakthivelmanii enabled auto-merge (squash) July 16, 2026 09:13
@sakthivelmanii
sakthivelmanii merged commit 9019b2a into main Jul 16, 2026
40 checks passed
@sakthivelmanii
sakthivelmanii deleted the fix-spanner-samples-pytest-asyncio-v2 branch July 16, 2026 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants